]> git.itanic.dy.fi Git - linux-stable/commitdiff
bcachefs: Fix -Wself-assign
authorNick Desaulniers <ndesaulniers@google.com>
Tue, 19 Sep 2023 20:38:31 +0000 (13:38 -0700)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:10:14 +0000 (17:10 -0400)
Fixes the following observed error reported by Nathan on IRC.

  fs/bcachefs/io_misc.c:467:6: error: explicitly assigning value of
  variable of type 'int' to itself [-Werror,-Wself-assign]
    467 |         ret = ret;
        |         ~~~ ^ ~~~

Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/io_misc.c

index 668493bcfe36bbf81c8627e1cf6680a94b821660..32432bdddac46ab18ab04172c2fded5e0bccb148 100644 (file)
@@ -462,9 +462,9 @@ case LOGGED_OP_FINSERT_shift_extents:
                                bch2_logged_op_update(trans, &op->k_i));
        }
 
-       fallthrough;
+       break;
 case LOGGED_OP_FINSERT_finish:
-       ret = ret;
+       break;
        }
 err:
        bch2_logged_op_finish(trans, op_k);