]> git.itanic.dy.fi Git - linux-stable/commitdiff
PM / sleep: fix device reference leak in test_suspend
authorJohan Hovold <johan@kernel.org>
Tue, 1 Nov 2016 10:49:56 +0000 (11:49 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 24 Nov 2016 15:23:57 +0000 (16:23 +0100)
commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream.

Make sure to drop the reference taken by class_find_device() after
opening the RTC device.

Fixes: 77437fd4e61f (pm: boot time suspend selftest)
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
kernel/power/suspend_test.c

index 269b097e78eaa03d590b7c930badeca3015ac75f..743615bfdcecb8da3d5616dbcba27df75ed7c5d8 100644 (file)
@@ -169,8 +169,10 @@ static int __init test_suspend(void)
 
        /* RTCs have initialized by now too ... can we use one? */
        dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
-       if (dev)
+       if (dev) {
                rtc = rtc_class_open(dev_name(dev));
+               put_device(dev);
+       }
        if (!rtc) {
                printk(warn_no_rtc);
                goto done;