]> git.itanic.dy.fi Git - linux-stable/commitdiff
clk: nomadik: Add missing of_node_put()
authorLiang He <windhl@126.com>
Fri, 17 Jun 2022 01:43:08 +0000 (09:43 +0800)
committerStephen Boyd <sboyd@kernel.org>
Fri, 19 Aug 2022 21:24:27 +0000 (14:24 -0700)
In nomadik_src_init(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220617014308.4001511-1-windhl@126.com
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-nomadik.c

index bad2677e11aeb6e87ce1c04a6fa4b738550153de..71fbe687fa7b697d9aee68132a3bf412940905d6 100644 (file)
@@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
        if (!src_base) {
                pr_err("%s: must have src parent node with REGS (%pOFn)\n",
                       __func__, np);
-               return;
+               goto out_put;
        }
 
        /* Set all timers to use the 2.4 MHz TIMCLK */
@@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
        }
        writel(val, src_base + SRC_XTALCR);
        register_reboot_notifier(&nomadik_clk_reboot_notifier);
+
+out_put:
+       of_node_put(np);
 }
 
 /**