]> git.itanic.dy.fi Git - linux-stable/commitdiff
staging: vc04_services: remove unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 31 Oct 2023 08:59:34 +0000 (11:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Nov 2023 12:47:56 +0000 (12:47 +0000)
We ensured that "service" as non-NULL in the previous if statement so
there is no need to check again here.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/1dff4d9b-d067-4525-95e0-ffdc1185cccd@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

index 39b857da2d4294f0fd8a82270a6fd0fb1b35ce8b..a0117efa299156fb2d285bcbc7126314be471c73 100644 (file)
@@ -2040,8 +2040,7 @@ sync_func(void *v)
                        continue;
                }
 
-               svc_fourcc = service ? service->base.fourcc
-                                    : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
+               svc_fourcc = service->base.fourcc;
 
                vchiq_log_trace(state->dev, VCHIQ_SYNC,
                                "Rcvd Msg %s from %p4cc s:%d d:%d len:%d",