]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests: tls: increase the wait in poll_partial_rec_async
authorJakub Kicinski <kuba@kernel.org>
Tue, 13 Feb 2024 14:20:55 +0000 (06:20 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 15 Feb 2024 02:02:02 +0000 (18:02 -0800)
Test runners on debug kernels occasionally fail with:

 # #  RUN           tls_err.13_aes_gcm.poll_partial_rec_async ...
 # # tls.c:1883:poll_partial_rec_async:Expected poll(&pfd, 1, 5) (0) == 1 (1)
 # # tls.c:1870:poll_partial_rec_async:Expected status (256) == 0 (0)
 # # poll_partial_rec_async: Test failed at step #17
 # #          FAIL  tls_err.13_aes_gcm.poll_partial_rec_async
 # not ok 699 tls_err.13_aes_gcm.poll_partial_rec_async
 # # FAILED: 698 / 699 tests passed.

This points to the second poll() in the test which is expected
to wait for the sender to send the rest of the data.
Apparently under some conditions that doesn't happen within 5ms,
bump the timeout to 20ms.

Fixes: 23fcb62bc19c ("selftests: tls: add tests for poll behavior")
Link: https://lore.kernel.org/r/20240213142055.395564-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/tls.c

index bc36c91c4480f51fa52bf713e4eeb11ff2575eb0..49c84602707f89d6f901ee60b63c4e5dfe75f8c8 100644 (file)
@@ -1874,13 +1874,13 @@ TEST_F(tls_err, poll_partial_rec_async)
                /* Child should sleep in poll(), never get a wake */
                pfd.fd = self->cfd2;
                pfd.events = POLLIN;
-               EXPECT_EQ(poll(&pfd, 1, 5), 0);
+               EXPECT_EQ(poll(&pfd, 1, 20), 0);
 
                EXPECT_EQ(write(p[1], &token, 1), 1); /* Barrier #1 */
 
                pfd.fd = self->cfd2;
                pfd.events = POLLIN;
-               EXPECT_EQ(poll(&pfd, 1, 5), 1);
+               EXPECT_EQ(poll(&pfd, 1, 20), 1);
 
                exit(!_metadata->passed);
        }