]> git.itanic.dy.fi Git - linux-stable/commitdiff
mmc: cqhci: Warn of halt or task clear failure
authorAdrian Hunter <adrian.hunter@intel.com>
Fri, 3 Nov 2023 08:47:19 +0000 (10:47 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 14 Nov 2023 16:15:07 +0000 (17:15 +0100)
A correctly operating controller should successfully halt and clear tasks.
Failure may result in errors elsewhere, so promote messages from debug to
warnings.

Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
Cc: stable@vger.kernel.org
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20231103084720.6886-6-adrian.hunter@intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/cqhci-core.c

index 15f5a069af1fc13f93e38ace6ba605fcd1683576..948799a0980caa2ce70d47ac74971f8b5e61b119 100644 (file)
@@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host *mmc, unsigned int timeout)
        ret = cqhci_tasks_cleared(cq_host);
 
        if (!ret)
-               pr_debug("%s: cqhci: Failed to clear tasks\n",
-                        mmc_hostname(mmc));
+               pr_warn("%s: cqhci: Failed to clear tasks\n",
+                       mmc_hostname(mmc));
 
        return ret;
 }
@@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc, unsigned int timeout)
        ret = cqhci_halted(cq_host);
 
        if (!ret)
-               pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
+               pr_warn("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
 
        return ret;
 }