platform/x86: x86-android-tablets: Fix an IS_ERR() vs NULL check in probe

The spi_new_device() function returns NULL on error, it doesn't return
error pointers.

Fixes: 70505ea6de24 ("platform/x86: x86-android-tablets: Add support for SPI device instantiation")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/4b1b2395-c7c5-44a4-b0b0-6d091c7f46a2@moroto.mountain
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c
index 6a5975ac3286583db5923fa7ad1c1a6b8e679bf0..f8221a15575b327c78df4edb191fdc28c52fe2c1 100644 (file)
--- a/drivers/platform/x86/x86-android-tablets/core.c
+++ b/drivers/platform/x86/x86-android-tablets/core.c
@@ -220,8 +220,8 @@ static __init int x86_instantiate_spi_dev(const struct x86_dev_info *dev_info, i
 
        spi_devs[idx] = spi_new_device(controller, &board_info);
        put_device(&controller->dev);
-       if (IS_ERR(spi_devs[idx]))
-               return dev_err_probe(&controller->dev, PTR_ERR(spi_devs[idx]),
+       if (!spi_devs[idx])
+               return dev_err_probe(&controller->dev, -ENOMEM,
                                     "creating SPI-device %d\n", idx);
 
        return 0;