]> git.itanic.dy.fi Git - linux-stable/commitdiff
dax: Check page->mapping isn't NULL
authorMatthew Wilcox <willy@infradead.org>
Tue, 27 Nov 2018 21:16:33 +0000 (13:16 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 08:24:41 +0000 (09:24 +0100)
commit c93db7bb6ef3251e0ea48ade311d3e9942748e1c upstream.

If we race with inode destroy, it's possible for page->mapping to be
NULL before we even enter this routine, as well as after having slept
waiting for the dax entry to become unlocked.

Fixes: c2a7d2a11552 ("filesystem-dax: Introduce dax_lock_mapping_entry()")
Cc: <stable@vger.kernel.org>
Reported-by: Jan Kara <jack@suse.cz>
Signed-off-by: Matthew Wilcox <willy@infradead.org>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/dax.c

index b0cd1364c68fa60d8bcee3e6ad9ae1bdb0a884de..3a2682a6c8324c915257767f438346159173871d 100644 (file)
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -423,7 +423,7 @@ bool dax_lock_mapping_entry(struct page *page)
        for (;;) {
                mapping = READ_ONCE(page->mapping);
 
-               if (!dax_mapping(mapping))
+               if (!mapping || !dax_mapping(mapping))
                        break;
 
                /*