]> git.itanic.dy.fi Git - linux-stable/commitdiff
arch_topology: Add support to parse and detect cache attributes
authorSudeep Holla <sudeep.holla@arm.com>
Mon, 4 Jul 2022 10:15:53 +0000 (11:15 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 4 Jul 2022 15:22:28 +0000 (16:22 +0100)
Currently ACPI populates just the minimum information about the last
level cache from PPTT in order to feed the same to build sched_domains.
Similar support for DT platforms is not present.

In order to enable the same, the entire cache hierarchy information can
be built as part of CPU topoplogy parsing both on ACPI and DT platforms.

Note that this change builds the cacheinfo early even on ACPI systems,
but the current mechanism of building llc_sibling mask remains unchanged.

Link: https://lore.kernel.org/r/20220704101605.1318280-10-sudeep.holla@arm.com
Tested-by: Ionela Voinescu <ionela.voinescu@arm.com>
Tested-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/base/arch_topology.c

index 579c851a2bd74a5a362621d41a844e1d5124e381..e2f7d9ea558e9f38256e85e1a39611fd99fbfcfd 100644 (file)
@@ -7,6 +7,7 @@
  */
 
 #include <linux/acpi.h>
+#include <linux/cacheinfo.h>
 #include <linux/cpu.h>
 #include <linux/cpufreq.h>
 #include <linux/device.h>
@@ -780,15 +781,28 @@ __weak int __init parse_acpi_topology(void)
 #if defined(CONFIG_ARM64) || defined(CONFIG_RISCV)
 void __init init_cpu_topology(void)
 {
+       int ret, cpu;
+
        reset_cpu_topology();
+       ret = parse_acpi_topology();
+       if (!ret)
+               ret = of_have_populated_dt() && parse_dt_topology();
 
-       /*
-        * Discard anything that was parsed if we hit an error so we
-        * don't use partial information.
-        */
-       if (parse_acpi_topology())
-               reset_cpu_topology();
-       else if (of_have_populated_dt() && parse_dt_topology())
+       if (ret) {
+               /*
+                * Discard anything that was parsed if we hit an error so we
+                * don't use partial information.
+                */
                reset_cpu_topology();
+               return;
+       }
+
+       for_each_possible_cpu(cpu) {
+               ret = detect_cache_attributes(cpu);
+               if (ret) {
+                       pr_info("Early cacheinfo failed, ret = %d\n", ret);
+                       break;
+               }
+       }
 }
 #endif