]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests: forwarding: lib: quote the sysctl values
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 8 Feb 2023 03:21:10 +0000 (11:21 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 9 Feb 2023 10:05:38 +0000 (11:05 +0100)
When set/restore sysctl value, we should quote the value as some keys
may have multi values, e.g. net.ipv4.ping_group_range

Fixes: f5ae57784ba8 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20230208032110.879205-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/forwarding/lib.sh

index 1c4f866de7d7d6902cb80ac2d34028e95994c4b4..3d8e4ebda1b648dbf751788a61b2d1bde78ce116 100755 (executable)
@@ -914,14 +914,14 @@ sysctl_set()
        local value=$1; shift
 
        SYSCTL_ORIG[$key]=$(sysctl -n $key)
-       sysctl -qw $key=$value
+       sysctl -qw $key="$value"
 }
 
 sysctl_restore()
 {
        local key=$1; shift
 
-       sysctl -qw $key=${SYSCTL_ORIG["$key"]}
+       sysctl -qw $key="${SYSCTL_ORIG[$key]}"
 }
 
 forwarding_enable()