]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: qca_spi: Avoid high load if QCA7000 is not available
authorStefan Wahren <stefan.wahren@i2se.com>
Wed, 14 Jun 2023 21:06:56 +0000 (23:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jun 2023 08:18:38 +0000 (10:18 +0200)
[ Upstream commit 92717c2356cb62c89e8a3dc37cbbab2502562524 ]

In case the QCA7000 is not available via SPI (e.g. in reset),
the driver will cause a high load. The reason for this is
that the synchronization is never finished and schedule()
is never called. Since the synchronization is not timing
critical, it's safe to drop this from the scheduling condition.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qualcomm/qca_spi.c

index 15591ad5fe4eaf87d44888a54aad559422b5ee83..db6817de24a141d2dbc20c0c5023a7120b1f966d 100644 (file)
@@ -574,8 +574,7 @@ qcaspi_spi_thread(void *data)
        while (!kthread_should_stop()) {
                set_current_state(TASK_INTERRUPTIBLE);
                if ((qca->intr_req == qca->intr_svc) &&
-                   (qca->txr.skb[qca->txr.head] == NULL) &&
-                   (qca->sync == QCASPI_SYNC_READY))
+                   !qca->txr.skb[qca->txr.head])
                        schedule();
 
                set_current_state(TASK_RUNNING);