]> git.itanic.dy.fi Git - linux-stable/commitdiff
nfsd: remove unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 4 Dec 2023 12:30:06 +0000 (15:30 +0300)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 7 Jan 2024 22:54:26 +0000 (17:54 -0500)
We check "state" for NULL on the previous line so it can't be NULL here.
No need to check again.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202312031425.LffZTarR-lkp@intel.com/
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c

index 3edbfa0233e68a5c3631faddc5ab5b177ef3eefb..2fa54cfd4882307e87e9c109070ecdc25a3db401 100644 (file)
@@ -6575,7 +6575,7 @@ __be32 manage_cpntf_state(struct nfsd_net *nn, stateid_t *st,
        spin_unlock(&nn->s2s_cp_lock);
        if (!state)
                return nfserr_bad_stateid;
-       if (!clp && state)
+       if (!clp)
                *cps = state;
        return 0;
 }