]> git.itanic.dy.fi Git - linux-stable/commitdiff
platform/x86/dell: alienware-wmi: Use kasprintf()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 12 Nov 2023 07:44:15 +0000 (08:44 +0100)
committerHans de Goede <hdegoede@redhat.com>
Mon, 20 Nov 2023 13:05:04 +0000 (14:05 +0100)
Use kasprintf() instead of hand writing it.
This saves the need of an intermediate buffer.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/f2b2c9e5d80550e480a627c1b2139d5cc9472ffa.1699775015.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/dell/alienware-wmi.c

index a9477e5432e4abec88710cf62f32ff7b114a3de3..f5ee62ce175399a68f095c99b0b767b46630e6a9 100644 (file)
@@ -429,7 +429,6 @@ static DEVICE_ATTR(lighting_control_state, 0644, show_control_state,
 static int alienware_zone_init(struct platform_device *dev)
 {
        u8 zone;
-       char buffer[10];
        char *name;
 
        if (interface == WMAX) {
@@ -466,8 +465,7 @@ static int alienware_zone_init(struct platform_device *dev)
                return -ENOMEM;
 
        for (zone = 0; zone < quirks->num_zones; zone++) {
-               sprintf(buffer, "zone%02hhX", zone);
-               name = kstrdup(buffer, GFP_KERNEL);
+               name = kasprintf(GFP_KERNEL, "zone%02hhX", zone);
                if (name == NULL)
                        return 1;
                sysfs_attr_init(&zone_dev_attrs[zone].attr);