]> git.itanic.dy.fi Git - linux-stable/commitdiff
kconfig: remove redundant NULL pointer check before free()
authorMasahiro Yamada <masahiroy@kernel.org>
Sun, 3 Dec 2023 10:25:28 +0000 (19:25 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Thu, 28 Dec 2023 07:22:47 +0000 (16:22 +0900)
Passing NULL to free() is allowed and is a no-op.

Remove redundant NULL pointer checks.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/confdata.c
scripts/kconfig/util.c

index bd14aae1db582f26bbd0851af3e8a58ab42acc29..f1197e67243161db800ef81e111b374a85a7056a 100644 (file)
@@ -432,8 +432,7 @@ int conf_read_simple(const char *name, int def)
                case S_INT:
                case S_HEX:
                case S_STRING:
-                       if (sym->def[def].val)
-                               free(sym->def[def].val);
+                       free(sym->def[def].val);
                        /* fall through */
                default:
                        sym->def[def].val = NULL;
index b78f114ad48cc5bac6e57246f8a2df4dabc0271d..92e5b2b9761d70966279ac0159769adf580110fa 100644 (file)
@@ -42,8 +42,7 @@ struct gstr str_new(void)
 /* Free storage for growable string */
 void str_free(struct gstr *gs)
 {
-       if (gs->s)
-               free(gs->s);
+       free(gs->s);
        gs->s = NULL;
        gs->len = 0;
 }