media: ov2740: Improve ov2740_check_hwcfg() error reporting

Make ov2740_check_hwcfg() report an error on failure in all error paths,
so that it is always clear why the probe() failed.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
index 06427e886d15102cb3e99e555140754e93b48eb2..1cbe0ac16995190f062363d2f36570773111a56c 100644 (file)
--- a/drivers/media/i2c/ov2740.c
+++ b/drivers/media/i2c/ov2740.c
@@ -940,7 +940,8 @@ static int ov2740_check_hwcfg(struct device *dev)
        ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
        if (ret) {
                fwnode_handle_put(ep);
-               return ret;
+               return dev_err_probe(dev, ret,
+                                    "reading clock-frequency property\n");
        }
 
        if (mclk != OV2740_MCLK) {
@@ -953,7 +954,7 @@ static int ov2740_check_hwcfg(struct device *dev)
        ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
        fwnode_handle_put(ep);
        if (ret)
-               return ret;
+               return dev_err_probe(dev, ret, "parsing endpoint failed\n");
 
        if (bus_cfg.bus.mipi_csi2.num_data_lanes != OV2740_DATA_LANES) {
                ret = dev_err_probe(dev, -EINVAL,