drm/amd/pm: downgrade log level upon SMU IF version mismatch

SMU IF version mismatch as a warning message exists widely
after asic production, however, due to this log level setting,
such mismatch warning will be caught by automation test like
IGT and reported as a fake error after checking. As such mismatch
does not break anything, to reduce confusion, downgrade it from
dev_warn to dev_info.

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
index 6492d69e2e60fa4fd504dff8620f75b8f32c4dbf..e1ef88ee1ed393fb768934dab53c16ae3cff981a 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
@@ -256,7 +256,7 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)
         * to be backward compatible.
         * 2. New fw usually brings some optimizations. But that's visible
         * only on the paired driver.
-        * Considering above, we just leave user a warning message instead
+        * Considering above, we just leave user a verbal message instead
         * of halt driver loading.
         */
        if (if_version != smu->smc_driver_if_version) {
@@ -264,7 +264,7 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)
                        "smu fw program = %d, version = 0x%08x (%d.%d.%d)\n",
                        smu->smc_driver_if_version, if_version,
                        smu_program, smu_version, smu_major, smu_minor, smu_debug);
-               dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
+               dev_info(smu->adev->dev, "SMU driver if version not matched\n");
        }
 
        return ret;

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c
index 56a02bc60ceeedd10daa4fdf5973439f3f1d1341..c788aa7a99a9e745d43edeabe2a5740d2e0d10ac 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c
@@ -93,7 +93,7 @@ int smu_v12_0_check_fw_version(struct smu_context *smu)
         * to be backward compatible.
         * 2. New fw usually brings some optimizations. But that's visible
         * only on the paired driver.
-        * Considering above, we just leave user a warning message instead
+        * Considering above, we just leave user a verbal message instead
         * of halt driver loading.
         */
        if (if_version != smu->smc_driver_if_version) {
@@ -101,7 +101,7 @@ int smu_v12_0_check_fw_version(struct smu_context *smu)
                        "smu fw program = %d, smu fw version = 0x%08x (%d.%d.%d)\n",
                        smu->smc_driver_if_version, if_version,
                        smu_program, smu_version, smu_major, smu_minor, smu_debug);
-               dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
+               dev_info(smu->adev->dev, "SMU driver if version not matched\n");
        }
 
        return ret;

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
index 66e9cb21497b56cf5f6d1fc83998a51e56962887..a52ed0580fd7ef74373b9532be2420c64b6cc650 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
@@ -311,7 +311,7 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
         * to be backward compatible.
         * 2. New fw usually brings some optimizations. But that's visible
         * only on the paired driver.
-        * Considering above, we just leave user a warning message instead
+        * Considering above, we just leave user a verbal message instead
         * of halt driver loading.
         */
        if (if_version != smu->smc_driver_if_version) {
@@ -319,7 +319,7 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
                         "smu fw program = %d, smu fw version = 0x%08x (%d.%d.%d)\n",
                         smu->smc_driver_if_version, if_version,
                         smu_program, smu_version, smu_major, smu_minor, smu_debug);
-               dev_warn(adev->dev, "SMU driver if version not matched\n");
+               dev_info(adev->dev, "SMU driver if version not matched\n");
        }
 
        return ret;