]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/exynos: vidi: fix a wrong error return
authorInki Dae <inki.dae@samsung.com>
Thu, 18 May 2023 23:55:05 +0000 (08:55 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jun 2023 08:14:21 +0000 (10:14 +0200)
[ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ]

Fix a wrong error return by dropping an error return.

When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info
then only what we have to is to free ctx->raw_edid so that driver removing
can work correctly - it's not an error case.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/exynos/exynos_drm_vidi.c

index 53e03f8af3d5ecd4dda4ec649a4e17017cc693c4..f36d4df4d481d9fa98ab68ae6df7bdedcc21ab72 100644 (file)
@@ -480,8 +480,6 @@ static int vidi_remove(struct platform_device *pdev)
        if (ctx->raw_edid != (struct edid *)fake_edid_info) {
                kfree(ctx->raw_edid);
                ctx->raw_edid = NULL;
-
-               return -EINVAL;
        }
 
        component_del(&pdev->dev, &vidi_component_ops);