]> git.itanic.dy.fi Git - linux-stable/commitdiff
fbdev: omapfb: panel-tpo-td043mtea1: fix error code in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 15 May 2023 10:32:47 +0000 (13:32 +0300)
committerHelge Deller <deller@gmx.de>
Fri, 19 May 2023 14:10:39 +0000 (16:10 +0200)
This was using the wrong variable, "r", instead of "ddata->vcc_reg", so
it returned success instead of a negative error code.

Fixes: 0d3dbeb8142a ("video: fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c

index 1eaa35c278359836ebd4860af036b42fce2d010b..477789cff8e08d5e620a0754feb1f1dba6008370 100644 (file)
@@ -491,7 +491,8 @@ static int tpo_td043_probe(struct spi_device *spi)
 
        ddata->vcc_reg = devm_regulator_get(&spi->dev, "vcc");
        if (IS_ERR(ddata->vcc_reg)) {
-               r = dev_err_probe(&spi->dev, r, "failed to get LCD VCC regulator\n");
+               r = dev_err_probe(&spi->dev, PTR_ERR(ddata->vcc_reg),
+                                 "failed to get LCD VCC regulator\n");
                goto err_regulator;
        }