]> git.itanic.dy.fi Git - linux-stable/commitdiff
tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning
authorSerge Semin <fancer.lancer@gmail.com>
Thu, 15 Feb 2024 17:17:29 +0000 (20:17 +0300)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:10 +0000 (18:17 -0400)
[ Upstream commit 188942f05ce45f80c06f7242ad7478bd204c3387 ]

mips_ejtag_fdc_encode() method expects having a first argument passed of
the "u8 **" type, meanwhile the driver passes the "const char **" type.
That causes the next build-warning:

drivers/tty/mips_ejtag_fdc.c: In function ‘mips_ejtag_fdc_console_write’:
drivers/tty/mips_ejtag_fdc.c:343:32: error: passing argument 1 of ‘mips_ejtag_fdc_encode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   word = mips_ejtag_fdc_encode(&buf_ptr, &buf_len, 1);
                                ^
drivers/tty/mips_ejtag_fdc.c:216:24: note: expected ‘const u8 ** {aka const unsigned char **}’ but argument is of type ‘const char **’
 static struct fdc_word mips_ejtag_fdc_encode(const u8 **ptrs,
                        ^~~~~~~~~~~~~~~~~~~~~

Fix it by altering the type of the pointer which is passed to the
mips_ejtag_fdc_encode() method.

Fixes: ce7cbd9a6c81 ("tty: mips_ejtag_fdc: use u8 for character pointers")
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/mips_ejtag_fdc.c

index aac80b69a069c38b12f85c8bcb4475e36729d83e..afbf7738c7c47c3377560a3288fa95083dd1c6b0 100644 (file)
@@ -309,7 +309,7 @@ static void mips_ejtag_fdc_console_write(struct console *c, const char *s,
        unsigned int i, buf_len, cpu;
        bool done_cr = false;
        char buf[4];
-       const char *buf_ptr = buf;
+       const u8 *buf_ptr = buf;
        /* Number of bytes of input data encoded up to each byte in buf */
        u8 inc[4];