]> git.itanic.dy.fi Git - linux-stable/commitdiff
i2c: mpc: drop release for resource allocated with devm_*
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 12 Apr 2021 16:00:26 +0000 (16:00 +0000)
committerWolfram Sang <wsa@kernel.org>
Tue, 13 Apr 2021 12:19:36 +0000 (14:19 +0200)
It's not necessary to release resource which allocated with devm_*
and those release may leads to a double free. And also remove useless
irq_dispose_mapping() call since mapping not created.

Fixes: 09aab7add7bf ("i2c: mpc: use device managed APIs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mpc.c

index 46cdb36e2f9b797d5d2fc0c789915ec3ac5ca045..6e5614acebacc5e76d652fccb29fe978db378706 100644 (file)
@@ -759,12 +759,6 @@ static int fsl_i2c_remove(struct platform_device *op)
        if (i2c->clk_per)
                clk_disable_unprepare(i2c->clk_per);
 
-       if (i2c->irq)
-               free_irq(i2c->irq, i2c);
-
-       irq_dispose_mapping(i2c->irq);
-       iounmap(i2c->base);
-       kfree(i2c);
        return 0;
 };