]> git.itanic.dy.fi Git - linux-stable/commitdiff
tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
authorSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Wed, 14 Feb 2024 00:19:56 +0000 (16:19 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:10:00 +0000 (13:10 +0200)
[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]

In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.

Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c

index 5fd9e594079cfda2bd9b2f3343e5698755993b44..ebda9c366b2ba341085587594c22517a40d52062 100644 (file)
@@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu)
        retval = fscanf(fp, "%d\n", &pkg);
        if (retval != 1)
                errx(1, "%s: failed to parse", pathname);
+       fclose(fp);
        return pkg;
 }