]> git.itanic.dy.fi Git - linux-stable/commitdiff
lib/fw_table: Remove acpi_parse_entries_array() export
authorDan Williams <dan.j.williams@intel.com>
Thu, 2 Nov 2023 22:07:02 +0000 (15:07 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 2 Nov 2023 22:17:21 +0000 (15:17 -0700)
Stephen reports that the ACPI helper library rework,
CONFIG_FIRMWARE_TABLE, introduces a new compiler warning:

    WARNING: modpost: vmlinux: acpi_parse_entries_array: EXPORT_SYMBOL used
    for init symbol. Remove __init or EXPORT_SYMBOL.

Delete this export as it turns out it is unneeded, and future work wraps
this in another exported helper. Note that in general
EXPORT_SYMBOL_ACPI_LIB() is needed for exporting symbols that are marked
__init_or_acpilib, but in this case no export is required.

Fixes: a103f46633fd ("acpi: Move common tables helper functions to common lib")
Cc: Dave Jiang <dave.jiang@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: http://lore.kernel.org/r/20231030160523.670a7569@canb.auug.org.au
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/169896282222.70775.940454758280866379.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
lib/fw_table.c

index e84bd0866e1046d17eb13d9d8e422e188eeb471f..b51f30a28e47b93f9b2b6bdd47227188d822e1a2 100644 (file)
@@ -186,4 +186,3 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
 
        return errs ? -EINVAL : count;
 }
-EXPORT_SYMBOL_GPL(acpi_parse_entries_array);