]> git.itanic.dy.fi Git - linux-stable/commitdiff
igb: Use FIELD_GET() to extract Link Width
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 21 Nov 2023 12:34:26 +0000 (14:34 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 12 Dec 2023 18:55:22 +0000 (10:55 -0800)
Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of
custom masking and shifting.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igb/e1000_mac.c

index caf91c6f52b4d03cabef2cc7fe6a4d545a0cc899..5a23b9cfec6c6fb4b1b2f8765e2093f6b8d6ae69 100644 (file)
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright(c) 2007 - 2018 Intel Corporation. */
 
+#include <linux/bitfield.h>
 #include <linux/if_ether.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
@@ -50,9 +51,8 @@ s32 igb_get_bus_info_pcie(struct e1000_hw *hw)
                        break;
                }
 
-               bus->width = (enum e1000_bus_width)((pcie_link_status &
-                                                    PCI_EXP_LNKSTA_NLW) >>
-                                                    PCI_EXP_LNKSTA_NLW_SHIFT);
+               bus->width = (enum e1000_bus_width)FIELD_GET(PCI_EXP_LNKSTA_NLW,
+                                                            pcie_link_status);
        }
 
        reg = rd32(E1000_STATUS);