]> git.itanic.dy.fi Git - linux-stable/commitdiff
modpost: disallow *driver to reference .meminit* sections
authorMasahiro Yamada <masahiroy@kernel.org>
Sun, 22 Oct 2023 17:06:06 +0000 (02:06 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 28 Oct 2023 12:31:22 +0000 (21:31 +0900)
Drivers must not reference .meminit* sections, which are discarded
when CONFIG_MEMORY_HOTPLUG=n.

The reason for whitelisting "*driver" in the section mismatch check
was to allow drivers to reference symbols annotated as __devinit or
__devexit that existed in the past.

Those annotations were removed by the following commits:

 - 54b956b90360 ("Remove __dev* markings from init.h")
 - 92e9e6d1f984 ("modpost.c: Stop checking __dev* section mismatches")

Remove the stale whitelist.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/mod/modpost.c

index bcc334b28a2c2476bf877fe4db228102f3d4699d..792ba9da0f270d8e6499a0c39fa226e1e03235ef 100644 (file)
@@ -1006,12 +1006,6 @@ static int secref_whitelist(const char *fromsec, const char *fromsym,
                                    "*_console")))
                return 0;
 
-       /* symbols in data sections that may refer to meminit sections */
-       if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
-           match(tosec, PATTERNS(ALL_XXXINIT_SECTIONS)) &&
-           match(fromsym, PATTERNS("*driver")))
-               return 0;
-
        /*
         * symbols in data sections must not refer to .exit.*, but there are
         * quite a few offenders, so hide these unless for W=1 builds until