]> git.itanic.dy.fi Git - linux-stable/commitdiff
can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs()
authorMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 6 Jul 2023 09:38:25 +0000 (11:38 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 28 Jul 2023 07:43:46 +0000 (09:43 +0200)
In gs_destroy_candev(), the netdev is unregistered first, then all
anchored TX URBs (dev->tx_submitted) are disposed with
usb_kill_anchored_urbs().

The call to usb_kill_anchored_urbs() is not needed, as
unregister_candev() calls gs_can_close(), which already disposes the
TX URBS.

Remove not needed call to usb_kill_anchored_urbs() from
gs_destroy_candev().

Link: https://lore.kernel.org/all/20230718-gs_usb-cleanups-v1-10-c3b9154ec605@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c

index 7718f6a4367eb61627ac250d45ad9b2b7f013b88..5a0017b9853212ebe27876316d593ce8c6f4249a 100644 (file)
@@ -1356,7 +1356,6 @@ static struct gs_can *gs_make_candev(unsigned int channel,
 static void gs_destroy_candev(struct gs_can *dev)
 {
        unregister_candev(dev->netdev);
-       usb_kill_anchored_urbs(&dev->tx_submitted);
        free_candev(dev->netdev);
 }