]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: dsa: hellcreek: Print warning only once
authorKurt Kanzenbach <kurt@linutronix.de>
Tue, 30 Aug 2022 16:34:48 +0000 (18:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Sep 2022 10:39:45 +0000 (12:39 +0200)
[ Upstream commit 52267ce25f60f37ae40ccbca0b21328ebae5ae75 ]

In case the source port cannot be decoded, print the warning only once. This
still brings attention to the user and does not spam the logs at the same time.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20220830163448.8921-1-kurt@linutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/dsa/tag_hellcreek.c

index eb204ad36eeec083f9f4bf8f9ff89baf06eea72f..846588c0070a5e2a43afee4a1bb553203643d51f 100644 (file)
@@ -45,7 +45,7 @@ static struct sk_buff *hellcreek_rcv(struct sk_buff *skb,
 
        skb->dev = dsa_master_find_slave(dev, 0, port);
        if (!skb->dev) {
-               netdev_warn(dev, "Failed to get source port: %d\n", port);
+               netdev_warn_once(dev, "Failed to get source port: %d\n", port);
                return NULL;
        }