]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/52xx: Add missing of_node_put() in media5200.c
authorLiang He <windhl@126.com>
Thu, 16 Jun 2022 14:40:07 +0000 (22:40 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:28:25 +0000 (17:28 +1000)
In media5200_init_irq(), of_find_compatible_node() will return a
node pointer with refcount incremented. The reference should be dropped
with of_node_put() in the failure path or when it is not used anymore.

Don't worry about 'fpga_np == NULL' as of_node_put() can correctly
handle that.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220616144007.3987743-1-windhl@126.com
arch/powerpc/platforms/52xx/media5200.c

index ee367ff3ec8a49e5ce80ba04638162f0b82fb0c9..33a35fff11b5cb043567fb1e70362fee85093cbb 100644 (file)
@@ -174,6 +174,8 @@ static void __init media5200_init_irq(void)
                goto out;
        pr_debug("%s: allocated irqhost\n", __func__);
 
+       of_node_put(fpga_np);
+
        irq_set_handler_data(cascade_virq, &media5200_irq);
        irq_set_chained_handler(cascade_virq, media5200_irq_cascade);
 
@@ -181,6 +183,7 @@ static void __init media5200_init_irq(void)
 
  out:
        pr_err("Could not find Media5200 FPGA; PCI interrupts will not work\n");
+       of_node_put(fpga_np);
 }
 
 /*