]> git.itanic.dy.fi Git - linux-stable/commitdiff
r8152: Run the unload routine if we have errors during probe
authorDouglas Anderson <dianders@chromium.org>
Fri, 20 Oct 2023 21:06:53 +0000 (14:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2023 10:46:17 +0000 (11:46 +0100)
The rtl8152_probe() function lacks a call to the chip-specific
unload() routine when it sees an error in probe. Add it in to match
the cleanup code in rtl8152_disconnect().

Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index 482957beae66bfc21ac36b62a16965de360e05f4..201c688e3e3f5428af51b4c39450709707d03fd2 100644 (file)
@@ -9783,6 +9783,8 @@ static int rtl8152_probe(struct usb_interface *intf,
 
 out1:
        tasklet_kill(&tp->tx_tl);
+       if (tp->rtl_ops.unload)
+               tp->rtl_ops.unload(tp);
        usb_set_intfdata(intf, NULL);
 out:
        free_netdev(netdev);