]> git.itanic.dy.fi Git - linux-stable/commitdiff
ASoC: amd: acp: remove unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 30 Oct 2023 09:03:51 +0000 (12:03 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 13 Nov 2023 01:26:16 +0000 (01:26 +0000)
The list iterator in a list_for_each_entry() loop can never be NULL.
Remove the check and pull the code in a tab.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/e376a712-e0c6-446f-9e0b-c444dd795cbb@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp63.c

index b871a216a6afec48413ea2378da5d0c46fd44255..4d342441a6506f4f7bd4f03c10f110321a95c0a1 100644 (file)
@@ -283,18 +283,16 @@ static int __maybe_unused acp63_pcm_resume(struct device *dev)
 
        spin_lock(&adata->acp_lock);
        list_for_each_entry(stream, &adata->stream_list, list) {
-               if (stream) {
-                       substream = stream->substream;
-                       if (substream && substream->runtime) {
-                               buf_in_frames = (substream->runtime->buffer_size);
-                               buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
-                               config_pte_for_stream(adata, stream);
-                               config_acp_dma(adata, stream, buf_size);
-                               if (stream->dai_id)
-                                       restore_acp_i2s_params(substream, adata, stream);
-                               else
-                                       restore_acp_pdm_params(substream, adata);
-                       }
+               substream = stream->substream;
+               if (substream && substream->runtime) {
+                       buf_in_frames = (substream->runtime->buffer_size);
+                       buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
+                       config_pte_for_stream(adata, stream);
+                       config_acp_dma(adata, stream, buf_size);
+                       if (stream->dai_id)
+                               restore_acp_i2s_params(substream, adata, stream);
+                       else
+                               restore_acp_pdm_params(substream, adata);
                }
        }
        spin_unlock(&adata->acp_lock);