]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests: pmtu.sh: fix result checking
authorHangbin Liu <liuhangbin@gmail.com>
Tue, 31 Oct 2023 03:47:32 +0000 (11:47 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Nov 2023 09:15:42 +0000 (09:15 +0000)
In the PMTU test, when all previous tests are skipped and the new test
passes, the exit code is set to 0. However, the current check mistakenly
treats this as an assignment, causing the check to pass every time.

Consequently, regardless of how many tests have failed, if the latest test
passes, the PMTU test will report a pass.

Fixes: 2a9d3716b810 ("selftests: pmtu.sh: improve the test result processing")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/pmtu.sh

index f838dd370f6af3ef252f0f77bf11e72aa80bed84..b3b2dc5a630cf2bd84df3c74e86652769e844a01 100755 (executable)
@@ -2048,7 +2048,7 @@ run_test() {
        case $ret in
                0)
                        all_skipped=false
-                       [ $exitcode=$ksft_skip ] && exitcode=0
+                       [ $exitcode -eq $ksft_skip ] && exitcode=0
                ;;
                $ksft_skip)
                        [ $all_skipped = true ] && exitcode=$ksft_skip