]> git.itanic.dy.fi Git - linux-stable/commitdiff
media: exynos4-is: Add missed check for pinctrl_lookup_state()
authorChuhong Yuan <hslester96@gmail.com>
Thu, 28 May 2020 06:41:47 +0000 (08:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 09:02:01 +0000 (11:02 +0200)
[ Upstream commit 18ffec750578f7447c288647d7282c7d12b1d969 ]

fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state().
Add the missed check to fix it.

Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/exynos4-is/media-dev.c

index ef6ccb5b89525025372bb9b6893f231a9df0e69b..cdaf3a8e2555e4bdb46ab77dd40c3053c509c11d 100644 (file)
@@ -1257,6 +1257,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
 
        pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
                                        PINCTRL_STATE_IDLE);
+       if (IS_ERR(pctl->state_idle))
+               return PTR_ERR(pctl->state_idle);
+
        return 0;
 }