]> git.itanic.dy.fi Git - linux-stable/commitdiff
perf intel-pt: Prefer get_unaligned_le64 to memcpy_le64
authorAdrian Hunter <adrian.hunter@intel.com>
Thu, 5 Oct 2023 19:04:51 +0000 (22:04 +0300)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 17 Oct 2023 19:40:50 +0000 (12:40 -0700)
Use get_unaligned_le64() instead of memcpy_le64(..., 8) because it produces
simpler code.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20231005190451.175568-6-adrian.hunter@intel.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c

index 7a90218aecb15ac8b10d020a9eb9646b4c886c0a..bccb988a7a443484c32a75e9514ce2351a89098b 100644 (file)
@@ -190,7 +190,7 @@ static int intel_pt_get_mnt(const unsigned char *buf, size_t len,
        if (len < 11)
                return INTEL_PT_NEED_MORE_BYTES;
        packet->type = INTEL_PT_MNT;
-       memcpy_le64(&packet->payload, buf + 3, 8);
+       packet->payload = get_unaligned_le64(buf + 3);
        return 11;
 }
 
@@ -302,7 +302,7 @@ static int intel_pt_get_bip_8(const unsigned char *buf, size_t len,
                return INTEL_PT_NEED_MORE_BYTES;
        packet->type = INTEL_PT_BIP;
        packet->count = buf[0] >> 3;
-       memcpy_le64(&packet->payload, buf + 1, 8);
+       packet->payload = get_unaligned_le64(buf + 1);
        return 9;
 }
 
@@ -341,7 +341,7 @@ static int intel_pt_get_evd(const unsigned char *buf, size_t len,
        packet->type = INTEL_PT_EVD;
        packet->count = buf[2] & 0x3f;
        packet->payload = buf[3];
-       memcpy_le64(&packet->payload, buf + 3, 8);
+       packet->payload = get_unaligned_le64(buf + 3);
        return 11;
 }