]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/embedded6xx: Add missing of_node_put()s
authorLiang He <windhl@126.com>
Sat, 18 Jun 2022 04:10:42 +0000 (12:10 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:28:26 +0000 (17:28 +1000)
Add missing of_node_put()s in various paths.

Signed-off-by: Liang He <windhl@126.com>
[mpe: Rewrite change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220618041042.4058066-1-windhl@126.com
arch/powerpc/platforms/embedded6xx/holly.c
arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c

index 78f2378d9223f3765df3f9c7fb1bd0467cb0887b..bebc5a972694e33d26809ce09557cc7a2593a4d3 100644 (file)
@@ -123,6 +123,8 @@ static void __init holly_init_pci(void)
        if (np)
                tsi108_setup_pci(np, HOLLY_PCI_CFG_PHYS, 1);
 
+       of_node_put(np);
+
        ppc_md.pci_exclude_device = holly_exclude_device;
        if (ppc_md.progress)
                ppc_md.progress("tsi108: resources set", 0x100);
@@ -184,6 +186,9 @@ static void __init holly_init_IRQ(void)
        tsi108_pci_int_init(cascade_node);
        irq_set_handler_data(cascade_pci_irq, mpic);
        irq_set_chained_handler(cascade_pci_irq, tsi108_irq_cascade);
+
+       of_node_put(tsi_pci);
+       of_node_put(cascade_node);
 #endif
        /* Configure MPIC outputs to CPU0 */
        tsi108_write_reg(TSI108_MPIC_OFFSET + 0x30c, 0);
@@ -210,6 +215,7 @@ static void __noreturn holly_restart(char *cmd)
        if (bridge) {
                prop = of_get_property(bridge, "reg", &size);
                addr = of_translate_address(bridge, prop);
+               of_node_put(bridge);
        }
        addr += (TSI108_PB_OFFSET + 0x414);
 
index 8b2b422103563ff6f8196a89651424692710d140..ddf0c652af8000f058594e43f1b841d928d0c683 100644 (file)
@@ -135,6 +135,9 @@ static void __init mpc7448_hpc2_init_IRQ(void)
        tsi108_pci_int_init(cascade_node);
        irq_set_handler_data(cascade_pci_irq, mpic);
        irq_set_chained_handler(cascade_pci_irq, tsi108_irq_cascade);
+
+       of_node_put(tsi_pci);
+       of_node_put(cascade_node);
 #endif
        /* Configure MPIC outputs to CPU0 */
        tsi108_write_reg(TSI108_MPIC_OFFSET + 0x30c, 0);