]> git.itanic.dy.fi Git - linux-stable/commitdiff
kcsan: remove rng selftest
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 17 Oct 2022 04:42:25 +0000 (22:42 -0600)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 17 Nov 2022 16:36:47 +0000 (17:36 +0100)
The first test of the kcsan selftest appears to test if get_random_u32()
returns two zeros in a row, and requires that it doesn't. This seems
like a bogus criteron. Remove it.

Acked-by: Marco Elver <elver@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
kernel/kcsan/selftest.c

index 00cdf8fa5693623273eb1244706ae3d5f6aeaab8..1740ce389e7fcde350c0657132f9b8f5945ea69c 100644 (file)
 
 #define ITERS_PER_TEST 2000
 
-/* Test requirements. */
-static bool __init test_requires(void)
-{
-       /* random should be initialized for the below tests */
-       return get_random_u32() + get_random_u32() != 0;
-}
-
 /*
  * Test watchpoint encode and decode: check that encoding some access's info,
  * and then subsequent decode preserves the access's info.
@@ -259,7 +252,6 @@ static int __init kcsan_selftest(void)
                        pr_err("selftest: " #do_test " failed");               \
        } while (0)
 
-       RUN_TEST(test_requires);
        RUN_TEST(test_encode_decode);
        RUN_TEST(test_matching_access);
        RUN_TEST(test_barrier);