]> git.itanic.dy.fi Git - linux-stable/commitdiff
serial: ucc_uart: Add of_node_put() in ucc_uart_remove()
authorLiang He <windhl@126.com>
Mon, 5 Dec 2022 08:54:37 +0000 (16:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jan 2023 14:51:09 +0000 (15:51 +0100)
In ucc_uart_probe(), we have added proper of_node_put() in the failure
paths. However, we miss it before we free *qe_port* in the remove() function.

Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20221205085437.1163682-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ucc_uart.c

index b09b6496ee3ebe881d1d8603d26148ef82baf782..32c7a5b43f8e94391c7b28c4c94b3cbbb8088756 100644 (file)
@@ -1468,6 +1468,8 @@ static int ucc_uart_remove(struct platform_device *ofdev)
 
        uart_remove_one_port(&ucc_uart_driver, &qe_port->port);
 
+       of_node_put(qe_port->np);
+
        kfree(qe_port);
 
        return 0;