net/sched: taprio: delete misleading comment about preallocating child qdiscs

As mentioned in commit af7b29b1deaa ("Revert "net/sched: taprio: make
qdisc_leaf() see the per-netdev-queue pfifo child qdiscs"") - unlike
mqprio, taprio doesn't use q->qdiscs[] only as a temporary transport
between Qdisc_ops :: init() and Qdisc_ops :: attach().

Delete the comment, which is just stolen from mqprio, but there, the
usage patterns are a lot different, and this is nothing but confusing.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20230807193324.4128292-5-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 831e6f3fda2a06c5e37241c44e9cea73b223ab9d..d5693bd52e930e6d1b4799faa75e1175b4a74973 100644 (file)
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -2099,11 +2099,8 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
                return -EOPNOTSUPP;
        }
 
-       /* pre-allocate qdisc, attachment can't fail */
-       q->qdiscs = kcalloc(dev->num_tx_queues,
-                           sizeof(q->qdiscs[0]),
+       q->qdiscs = kcalloc(dev->num_tx_queues, sizeof(q->qdiscs[0]),
                            GFP_KERNEL);
-
        if (!q->qdiscs)
                return -ENOMEM;