]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/i915: Do not print 'pxp init failed with 0' when it succeed
authorJosé Roberto de Souza <jose.souza@intel.com>
Wed, 20 Mar 2024 21:05:47 +0000 (14:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:38:00 +0000 (16:38 +0200)
[ Upstream commit d392e1b9c2e8c60550a2a467732107f0f98b8e97 ]

It is misleading, if the intention was to also print something
in case it succeed it should have a different string.

Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Fixes: 698e19da2914 ("drm/i915: Skip pxp init if gt is wedged")
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240320210547.71937-1-jose.souza@intel.com
(cherry picked from commit d437099ab21cd4c6ce5d578b765df642d759c929)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/i915/i915_driver.c

index c7d7c3b7ecc638f433b6b018c8b9562bf09eb0d6..9967148aedf15928131cf87c401354eeaea7e2c7 100644 (file)
@@ -799,7 +799,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                goto out_cleanup_modeset2;
 
        ret = intel_pxp_init(i915);
-       if (ret != -ENODEV)
+       if (ret && ret != -ENODEV)
                drm_dbg(&i915->drm, "pxp init failed with %d\n", ret);
 
        ret = intel_display_driver_probe(i915);