]> git.itanic.dy.fi Git - linux-stable/commitdiff
thermal: amlogic: Make amlogic_thermal_disable() return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 16 Nov 2023 11:26:35 +0000 (12:26 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 2 Jan 2024 08:33:18 +0000 (09:33 +0100)
amlogic_thermal_disable() returned zero unconditionally and
amlogic_thermal_remove() already ignores the return value.

Make it return no value and modify amlogic_thermal_suspend to not check
the value.

This patch introduces no semantic changes, but makes it more obvious for
a human reader that amlogic_thermal_suspend() cannot fail.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231116112633.668826-2-u.kleine-koenig@pengutronix.de
drivers/thermal/amlogic_thermal.c

index 5877cde25b79cf221c1d0537fc227b60b262a313..562f63b7bf2795d4de0b82cca34f84f889756be2 100644 (file)
@@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_thermal *data)
        return 0;
 }
 
-static int amlogic_thermal_disable(struct amlogic_thermal *data)
+static void amlogic_thermal_disable(struct amlogic_thermal *data)
 {
        regmap_update_bits(data->regmap, TSENSOR_CFG_REG1,
                           TSENSOR_CFG_REG1_ENABLE, 0);
        clk_disable_unprepare(data->clk);
-
-       return 0;
 }
 
 static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
@@ -302,7 +300,9 @@ static int __maybe_unused amlogic_thermal_suspend(struct device *dev)
 {
        struct amlogic_thermal *data = dev_get_drvdata(dev);
 
-       return amlogic_thermal_disable(data);
+       amlogic_thermal_disable(data);
+
+       return 0;
 }
 
 static int __maybe_unused amlogic_thermal_resume(struct device *dev)