]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: dsa: lantiq_gswip: ignore MDIO buses disabled in OF
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 4 Jan 2024 14:00:30 +0000 (16:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Jan 2024 11:56:35 +0000 (11:56 +0000)
If the "lantiq,xrx200-mdio" child has status = "disabled", the MDIO bus
creation should be avoided. Use of_device_is_available() to check for
that, and take advantage of 2 facts:

- of_device_is_available(NULL) returns false
- of_node_put(NULL) is a no-op

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lantiq_gswip.c

index a514e6c78c385c4d92441113eb5621354b4afc64..de48b194048f1ceffcb5282a7caa54593e062f89 100644 (file)
@@ -510,11 +510,11 @@ static int gswip_mdio(struct gswip_priv *priv)
        struct device_node *mdio_np, *switch_np = priv->dev->of_node;
        struct device *dev = priv->dev;
        struct mii_bus *bus;
-       int err;
+       int err = 0;
 
        mdio_np = of_get_compatible_child(switch_np, "lantiq,xrx200-mdio");
-       if (!mdio_np)
-               return 0;
+       if (!of_device_is_available(mdio_np))
+               goto out_put_node;
 
        bus = devm_mdiobus_alloc(dev);
        if (!bus) {