]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: dpaa: Fix dtsec check for PCS availability
authorSean Anderson <seanga2@gmail.com>
Tue, 3 Jan 2023 06:50:38 +0000 (01:50 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Jan 2023 09:23:17 +0000 (09:23 +0000)
We want to fail if the PCS is not available, not if it is available. Fix
this condition.

Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
Reported-by: Christian Zigotzky <info@xenosoft.de>
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fman/fman_dtsec.c

index d00bae15a9017d2e46dec8febc647f4721fce12d..d528ca681b6f4616de32dd9da7d0339509f8f707 100644 (file)
@@ -1430,7 +1430,7 @@ int dtsec_initialization(struct mac_device *mac_dev,
        dtsec->dtsec_drv_param->tx_pad_crc = true;
 
        phy_node = of_parse_phandle(mac_node, "tbi-handle", 0);
-       if (!phy_node || of_device_is_available(phy_node)) {
+       if (!phy_node || !of_device_is_available(phy_node)) {
                of_node_put(phy_node);
                err = -EINVAL;
                dev_err_probe(mac_dev->dev, err,