]> git.itanic.dy.fi Git - linux-stable/commitdiff
xen/events: fix error code in xen_bind_pirq_msi_to_irq()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 28 Nov 2023 06:52:41 +0000 (09:52 +0300)
committerJuergen Gross <jgross@suse.com>
Tue, 28 Nov 2023 11:48:27 +0000 (12:48 +0100)
Return -ENOMEM if xen_irq_init() fails.  currently the code returns an
uninitialized variable or zero.

Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Juergen Gross <jgross@ssue.com>
Link: https://lore.kernel.org/r/3b9ab040-a92e-4e35-b687-3a95890a9ace@moroto.mountain
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/events/events_base.c

index f5edb9e27e3ca1e33edd88fce970e57ca228430c..b8cfea7812d6b61110cc5e42fe4249d4578dc721 100644 (file)
@@ -1110,8 +1110,10 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
 
        for (i = 0; i < nvec; i++) {
                info = xen_irq_init(irq + i);
-               if (!info)
+               if (!info) {
+                       ret = -ENOMEM;
                        goto error_irq;
+               }
 
                irq_set_chip_and_handler_name(irq + i, &xen_pirq_chip, handle_edge_irq, name);