]> git.itanic.dy.fi Git - linux-stable/commitdiff
hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API
authorLiang He <windhl@126.com>
Fri, 16 Sep 2022 15:47:08 +0000 (23:47 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 19 Sep 2022 13:16:39 +0000 (06:16 -0700)
In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
the of_find_compatible_node() which will automatically call
of_node_put() for the 'from' argument.

Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Liang He <windhl@126.com>
Co-developed-by: Mengda Chen <chenmengda2009@163.com>
Signed-off-by: Mengda Chen <chenmengda2009@163.com>
Link: https://lore.kernel.org/r/20220916154708.3084515-1-chenmengda2009@163.com
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/gsc-hwmon.c

index d64be48f1ef6c51c2490ee633824440b068f00b3..b60ec95b5edbf248da1d4abfd1abff494180beaa 100644 (file)
@@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
        pdata->nchannels = nchannels;
 
        /* fan controller base address */
+       of_node_get(dev->parent->of_node);
        fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
        if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
                of_node_put(fan);