]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests/net: specify the interface when do arping
authorHangbin Liu <liuhangbin@gmail.com>
Sat, 2 Dec 2023 02:00:59 +0000 (10:00 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 5 Dec 2023 12:00:56 +0000 (13:00 +0100)
When do arping, the interface need to be specified. Or we will
get error: Interface "lo" is not ARPable. And the test failed.
]# ./arp_ndisc_untracked_subnets.sh
    TEST: test_arp:  accept_arp=0                                       [ OK ]
    TEST: test_arp:  accept_arp=1                                       [FAIL]
    TEST: test_arp:  accept_arp=2  same_subnet=0                        [ OK ]
    TEST: test_arp:  accept_arp=2  same_subnet=1                        [FAIL]

After fix:
]# ./arp_ndisc_untracked_subnets.sh
    TEST: test_arp:  accept_arp=0                                       [ OK ]
    TEST: test_arp:  accept_arp=1                                       [ OK ]
    TEST: test_arp:  accept_arp=2  same_subnet=0                        [ OK ]
    TEST: test_arp:  accept_arp=2  same_subnet=1                        [ OK ]

Fixes: 0ea7b0a454ca ("selftests: net: arp_ndisc_untracked_subnets: test for arp_accept and accept_untracked_na")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/arp_ndisc_untracked_subnets.sh

index c899b446acb624735b6dcb08fd8d415a049d6ed3..327427ec10f565545159df7790cbfb620c97ef0f 100755 (executable)
@@ -150,7 +150,7 @@ arp_test_gratuitous() {
        fi
        # Supply arp_accept option to set up which sets it in sysctl
        setup ${arp_accept}
-       ip netns exec ${HOST_NS} arping -A -U ${HOST_ADDR} -c1 2>&1 >/dev/null
+       ip netns exec ${HOST_NS} arping -A -I ${HOST_INTF} -U ${HOST_ADDR} -c1 2>&1 >/dev/null
 
        if verify_arp $1 $2; then
                printf "    TEST: %-60s  [ OK ]\n" "${test_msg[*]}"