]> git.itanic.dy.fi Git - linux-stable/commitdiff
can: at91_can: at91_chip_start(): don't disable IRQs twice
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 1 May 2023 16:14:41 +0000 (18:14 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 5 Oct 2023 19:46:33 +0000 (21:46 +0200)
In at91_chip_start() first all IRQs are disabled, they do not have to
be disabled again at the end of the function before the requested IRQs
are enabled.

Remove the 2nd disable of all IRQs at the end of the function.

Link: https://lore.kernel.org/all/20231005-at91_can-rx_offload-v2-14-9987d53600e0@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/at91_can.c

index f92d8a75d1b1fd2567a248a37c47d48bd86bbe59..3f3c6f2107a872a445f5e0584ea340bf02f2de40 100644 (file)
@@ -438,7 +438,6 @@ static void at91_chip_start(struct net_device *dev)
 
        /* Enable interrupts */
        reg_ier = get_irq_mb_rx(priv) | AT91_IRQ_ERRP | AT91_IRQ_ERR_FRAME;
-       at91_write(priv, AT91_IDR, AT91_IRQ_ALL);
        at91_write(priv, AT91_IER, reg_ier);
 }