]> git.itanic.dy.fi Git - linux-stable/commitdiff
platform/x86: wmi: Fix wmi_dev_probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 5 Jan 2024 13:47:54 +0000 (16:47 +0300)
committerHans de Goede <hdegoede@redhat.com>
Mon, 22 Jan 2024 10:37:27 +0000 (11:37 +0100)
This has a reversed if statement so it accidentally disables the wmi
method before returning.

Fixes: 704af3a40747 ("platform/x86: wmi: Remove chardev interface")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/9c81251b-bc87-4ca3-bb86-843dc85e5145@moroto.mountain
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/wmi.c

index d1df1a31de00844f662290802316a8e68515db2a..3c288e8f404beb5d4887235c85654e9ac77cd425 100644 (file)
@@ -896,7 +896,7 @@ static int wmi_dev_probe(struct device *dev)
        if (wdriver->probe) {
                ret = wdriver->probe(dev_to_wdev(dev),
                                find_guid_context(wblock, wdriver));
-               if (!ret) {
+               if (ret) {
                        if (ACPI_FAILURE(wmi_method_enable(wblock, false)))
                                dev_warn(dev, "Failed to disable device\n");