]> git.itanic.dy.fi Git - linux-stable/commitdiff
mm/damon/sysfs: eliminate potential uninitialized variable warning
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 6 Nov 2023 14:07:40 +0000 (17:07 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 15 Nov 2023 23:30:08 +0000 (15:30 -0800)
The "err" variable is not initialized if damon_target_has_pid(ctx) is
false and sys_target->regions->nr is zero.

Link: https://lkml.kernel.org/r/739e6aaf-a634-4e33-98a8-16546379ec9f@moroto.mountain
Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs.c

index e27846708b5a248b9632d662004a0d49a56844b7..1dfa96d4de99b09cec1dc98ad882f9a2601b87b7 100644 (file)
@@ -1172,7 +1172,7 @@ static int damon_sysfs_update_target(struct damon_target *target,
                struct damon_ctx *ctx,
                struct damon_sysfs_target *sys_target)
 {
-       int err;
+       int err = 0;
 
        if (damon_target_has_pid(ctx)) {
                err = damon_sysfs_update_target_pid(target, sys_target->pid);