]> git.itanic.dy.fi Git - linux-stable/commitdiff
net/mlx5e: Fix error code in mlx5e_tc_action_miss_mapping_get()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 13 Dec 2023 14:08:17 +0000 (17:08 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 14 Dec 2023 01:22:18 +0000 (17:22 -0800)
Preserve the error code if esw_add_restore_rule() fails.  Don't return
success.

Fixes: 6702782845a5 ("net/mlx5e: TC, Set CT miss to the specific ct action instance")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

index 4809a66f3491a6234f17675b3e550bb45bf3afaf..6106bbbe14de572fd1647192efecd7e8c2123427 100644 (file)
@@ -5736,8 +5736,10 @@ int mlx5e_tc_action_miss_mapping_get(struct mlx5e_priv *priv, struct mlx5_flow_a
 
        esw = priv->mdev->priv.eswitch;
        attr->act_id_restore_rule = esw_add_restore_rule(esw, *act_miss_mapping);
-       if (IS_ERR(attr->act_id_restore_rule))
+       if (IS_ERR(attr->act_id_restore_rule)) {
+               err = PTR_ERR(attr->act_id_restore_rule);
                goto err_rule;
+       }
 
        return 0;