]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: netdev_queue: netdev_txq_completed_mb(): fix wake condition
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 12 Jan 2024 16:13:14 +0000 (17:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Jan 2024 18:26:23 +0000 (18:26 +0000)
netif_txq_try_stop() uses "get_desc >= start_thrs" as the check for
the call to netif_tx_start_queue().

Use ">=" i netdev_txq_completed_mb(), too.

Fixes: c91c46de6bbc ("net: provide macros for commonly copied lockless queue stop/wake code")
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/netdev_queues.h

index d68b0a4834315062a4b1b450dd87fb66a76218c0..8b8ed4e13d74dfaa63ede54f00c3ba5aac2f6ee8 100644 (file)
@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue,
                netdev_txq_completed_mb(txq, pkts, bytes);              \
                                                                        \
                _res = -1;                                              \
-               if (pkts && likely(get_desc > start_thrs)) {            \
+               if (pkts && likely(get_desc >= start_thrs)) {           \
                        _res = 1;                                       \
                        if (unlikely(netif_tx_queue_stopped(txq)) &&    \
                            !(down_cond)) {                             \