]> git.itanic.dy.fi Git - linux-stable/commitdiff
irqchip/qcom-mpm: Fix IS_ERR() vs NULL check in qcom_mpm_init()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 1 Feb 2024 12:17:50 +0000 (15:17 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 13 Feb 2024 09:26:15 +0000 (10:26 +0100)
devm_ioremap() doesn't return error pointers, it returns NULL on error.
Update the check accordingly.

Fixes: 221b110d87c2 ("irqchip/qcom-mpm: Support passing a slice of SRAM as reg space")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/22e1f4de-edce-4791-bd2d-2b2e98529492@moroto.mountain
drivers/irqchip/irq-qcom-mpm.c

index cda5838d2232dc1971369b4c6e872d004263b8de..7942d8eb3d00eae5fa7e5718a05ef889bb8a82f0 100644 (file)
@@ -389,8 +389,8 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent)
                /* Don't use devm_ioremap_resource, as we're accessing a shared region. */
                priv->base = devm_ioremap(dev, res.start, resource_size(&res));
                of_node_put(msgram_np);
-               if (IS_ERR(priv->base))
-                       return PTR_ERR(priv->base);
+               if (!priv->base)
+                       return -ENOMEM;
        } else {
                /* Otherwise, fall back to simple MMIO. */
                priv->base = devm_platform_ioremap_resource(pdev, 0);