]> git.itanic.dy.fi Git - linux-stable/commitdiff
ASoC: audio-graph-card2: Add of_node_put() in fail path
authorLiang He <windhl@126.com>
Fri, 22 Jul 2022 14:18:01 +0000 (22:18 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 22 Jul 2022 20:27:55 +0000 (21:27 +0100)
In asoc_simple_parse_dai(), we should call of_node_put() for the
reference returned by of_graph_get_port_parent() in fail path.

Fixes: 6e5f68fe3f2d ("ASoC: add Audio Graph Card2 driver")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220722141801.1304854-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card2.c

index 18d053a0d05c7b2452d5302413db4a27b350a73f..8ac6df645ee6ce4b32c9aadd4229d92863be435c 100644 (file)
@@ -445,8 +445,10 @@ static int asoc_simple_parse_dai(struct device_node *ep,
         *    if he unbinded CPU or Codec.
         */
        ret = snd_soc_get_dai_name(&args, &dlc->dai_name);
-       if (ret < 0)
+       if (ret < 0) {
+               of_node_put(node);
                return ret;
+       }
 
        dlc->of_node = node;